Added proper handling of nifti RGB formats#46
Open
baishi wants to merge 2 commits intoHumanBrainProject:masterfrom
Open
Added proper handling of nifti RGB formats#46baishi wants to merge 2 commits intoHumanBrainProject:masterfrom
baishi wants to merge 2 commits intoHumanBrainProject:masterfrom
Conversation
added 2 commits
February 19, 2026 05:05
1. The format of (x, y, z, t, (uint8, uint8, uint8)) is supported and
mmap works out of the box
2. The format of (x, y, z, t, [('R', 'u1'), ('G', 'u1'), ('B', 'u1')])
structured rgb format is also supported. However, due to limitation
of nibabel, the full dataset need to be loaded into memory.
A warning is printed for this case
Collaborator
|
@baishi thanks for the PR. Is there a sample nifti where we can write test to prevent regression in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two formats of NIfTI are properly supported
A warning is printed for this case